Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(json type): keep JSON type as a Dict #261

Merged

Conversation

mostaphaRoudsari
Copy link
Member

Resolves #260

@coveralls
Copy link

coveralls commented Jan 28, 2021

Pull Request Test Coverage Report for Build 519038273

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 4 (50.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 49.585%

Changes Missing Coverage Covered Lines Changed/Added Lines %
queenbee/io/inputs/step.py 0 1 0.0%
queenbee/io/outputs/step.py 0 1 0.0%
Totals Coverage Status
Change from base Build 515488251: 0.0%
Covered Lines: 1373
Relevant Lines: 2769

💛 - Coveralls

@mostaphaRoudsari mostaphaRoudsari merged commit 6678f05 into pollination:master Jan 28, 2021
@mostaphaRoudsari mostaphaRoudsari deleted the revert-json-type branch January 28, 2021 20:28
@ladybugbot
Copy link

🎉 This PR is included in version 1.22.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Union[List, Dict]" breaks the C# SDK generation
3 participants