Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): Update schema URLs #295

Merged
merged 2 commits into from
Mar 11, 2021
Merged

fix(readme): Update schema URLs #295

merged 2 commits into from
Mar 11, 2021

Conversation

tymokvo
Copy link
Contributor

@tymokvo tymokvo commented Mar 6, 2021

Fix #294

@coveralls
Copy link

coveralls commented Mar 6, 2021

Pull Request Test Coverage Report for Build 644254523

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 60 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.4%) to 48.647%

Files with Coverage Reduction New Missed Lines %
queenbee/job/status.py 3 0.0%
queenbee/job/job.py 21 0.0%
queenbee/job/run.py 36 0.0%
Totals Coverage Status
Change from base Build 627208842: -0.4%
Covered Lines: 1384
Relevant Lines: 2845

💛 - Coveralls

@tymokvo
Copy link
Contributor Author

tymokvo commented Mar 6, 2021

This was so small I just did it through the UI. Hence, no fork branch.

@AntoineDao AntoineDao self-requested a review March 11, 2021 09:38
Copy link
Member

@AntoineDao AntoineDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very polite of you to leave this hanging rather than just merging it in 😂 It's such a small change I don't think this needs a review or a side branch. In future feel free to push such changes straight to master, we trust you!

Not sure if you were wanting this reviewed or checked but just in case you were waiting for it I set myself up as reviewer and am giving you an official 👍 of approval!

README.md Outdated Show resolved Hide resolved
@tymokvo tymokvo merged commit e963393 into master Mar 11, 2021
@ladybugbot
Copy link

🎉 This PR is included in version 1.24.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mostaphaRoudsari mostaphaRoudsari deleted the fix-schema-doc-links branch March 19, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema and ReDoc links are broken in top level Readme
4 participants