cleanup strdup nonsense using new opt pattern

[defunctzombie]

Avoid strdup where possible by just capturing the Handle value. We cannot simple capture the Utf8Value as there is no empty constructor.

Example of capturing handles and getting strings or NULL.

v8::Handle<v8::Value> extIdOpt;
v8::Handle<v8::Value> sysIdOpt;

//must be set to null in order for xmlCreateIntSubset to ignore them
if (args.Length() > 1 && args[1]->IsString()) {
    extIdOpt = args[1];
}
if (args.Length() > 2 && args[2]->IsString()) {
    sysIdOpt = args[2];
}

v8::String::Utf8Value extIdRaw(extIdOpt);
v8::String::Utf8Value sysIdRaw(sysIdOpt);

const char* extId = (extIdRaw.length()) ? *extIdRaw : NULL;
const char* sysId = (sysIdRaw.length()) ? *sysIdRaw : NULL;

[ncb000gt]

The only other place I found reference to strdup was in libxmljs.cc:80 using xmlMemoryStrdup. This isn't going to be replaced this way, and we probably don't want to change this as it is likely fundamental to libxml. :)

Anyway, the above commit should cover it.

[defunctzombie]

LGTM. If all tests pass merge it in!

[ncb000gt]

I've run the tests and while they fail, they are failing with a segfault in the ref_integrity tests. I took out the failing test and all is well so the code itself is good. I'll leave it in master (I'm not going to take out the failing test).

[defunctzombie]

Sounds good
On Jan 6, 2013 1:50 PM, "Nick Campbell" notifications@github.com wrote:

I've run the tests and while they fail, they are failing with a segfault
in the ref_integrity tests. I took out the failing test and all is well so
the code itself is good. I'll leave it in master (I'm not going to take out
the failing test).

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/179#issuecomment-11932313.