Code removal and clean up #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for splitting up yammer.js into multiple modules for each different resource type.
Rather than requiring the constructor and instance to be defined
separately this allows us to use the popular terse instantiation:
var yammer = require('yammer')({
access_token: 'topsecret'
});
Bearer tokens are used for authenticating requests rather than OAuth signatures (see: http://developer.yammer.com/authentication/).
Make use of the built-in JSON response parsing in `request` rather than using our own response body parser.
The built-in JSON parsing in request is now being used, so there's no need to test this explicitly.
The authentication header is now a simple bearer token, so this commit removes the extraneous _oauth method.
|
Do we need to update the package.json version number? Or should we do this stuff in a branch and make a minor/major release once we're done refactoring? |
|
Yes, but not just yet as there's more to do here. Even though the interface is changing there's no need to bump the major version since we're on version 0 and as per the semver spec the API is not guaranteed stable. |
Removes the trailing `.` and the option to specify a non-json response format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small changes to clean up the external interface (ed69208, b478a23, 6272cfe), bring the code inline with the documented authentication API (c4ce285, 0433d0d) and make better use of
request(3894771, dd7cb48).