if options object is empty, use process env

polotek · Sep 28, 2011 · 426de1c · 426de1c
1 parent 771ba34
commit 426de1c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/child_process.js b/lib/child_process.js
@@ -219,7 +219,7 @@ ChildProcess.prototype.spawn = function(path, args, options, customFds) {
       options.uid === undefined) {
     // Deprecated API: (path, args, options, env, customFds)
     cwd = '';
-    env = options || process.env;
+    env = process.env;
     customFds = customFds || [-1, -1, -1];
     setsid = false;
     uid = -1;

diff --git a/test/simple/test-child-process-env.js b/test/simple/test-child-process-env.js
@@ -42,7 +42,19 @@ child.stdout.addListener('data', function(chunk) {
   response += chunk;
 });
 
+var child2 = spawn('/usr/bin/env', [], {});
+var response2 = '';
+
+child2.stdout.setEncoding('utf8');
+
+child2.stdout.addListener('data', function(chunk) {
+  console.log('stdout2: ' + chunk);
+  response2 += chunk;
+});
+
 process.addListener('exit', function() {
   assert.ok(response.indexOf('HELLO=WORLD') >= 0);
   assert.ok(response.indexOf('FOO=BAR') >= 0);
+
+  assert.ok(response2.indexOf('PATH=') >= 0);
 });