Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small improvements to pgusinit #6

Merged
merged 4 commits into from Jul 2, 2023
Merged

small improvements to pgusinit #6

merged 4 commits into from Jul 2, 2023

Conversation

SuperIlu
Copy link

  • case insensitive command line parsing
  • fixed usage
  • added EXE path to usage

@SuperIlu SuperIlu mentioned this pull request Feb 25, 2023
Closed
kmeaw
kmeaw reviewed Mar 26, 2023
View reviewed changes
pgusinit/pgusinit.c Outdated Show resolved Hide resolved
polpo
polpo requested changes May 25, 2023
View reviewed changes
Copy link
Owner

@polpo polpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the small detail about the DMA interval max being 255. Sorry for taking so long to look at this... 🙃

pgusinit/pgusinit.c Outdated Show resolved Hide resolved
@SuperIlu
Copy link
Author

SuperIlu commented Jul 1, 2023

did the requested changes, please try to merge

@polpo polpo merged commit eeb23f1 into polpo:main Jul 2, 2023
@polpo
Copy link
Owner

polpo commented Jul 2, 2023

Thank you @SuperIlu!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmeaw kmeaw kmeaw left review comments

@polpo polpo polpo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperIlu @polpo @kmeaw