Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensorboard can be started multiple times for one project #51

Closed
jrozansk opened this issue Feb 26, 2018 · 2 comments
Closed

Tensorboard can be started multiple times for one project #51

jrozansk opened this issue Feb 26, 2018 · 2 comments

Comments

@jrozansk
Copy link

jrozansk commented Feb 26, 2018

Steps to reproduce:

  1. Create a project.
  2. Start tensorboard with polyaxon CLI.
    polyaxon project start_tensorboard
  3. Use polyaxon CLI again to start another tensorboard within the same project.
  4. Delete tensorboard twice.
    polyaxon project stop_tensorboard

Expected results:
It is up to authors how can it be handled.
Either not allowing creation of second tensorboard or possibility to choose which tensorboard to stop would be ok.

Actual results:
Only one tensorboard is stopped. Second remains running. Data scientists would be forced to approach k8s cluster and delete tensorboard manually.

Note: This occurs for version 0.0.3 released as chart.

@mmourafiq
Copy link
Contributor

Hi @jrozansk, I noticed that issue as well, also there's security problem involved by giving access to tensorboard over LoadBalancer/Ingress.

In the coming version, I fixed the issue with the security, i.e. tensorboard will be subject to the same permissions sat on the project by the user, and will not be visible on a separate LoadBlancer/Ingress.

I also added the possibility to start jupyter notebooks in the same fashion.

More or less the logic for creating tensorboards / jupyter notebooks is different, but I will keep in mind to test this use case again.

@mmourafiq
Copy link
Contributor

I am keeping this issue open, as I was able to reproduce it again.

mmourafiq pushed a commit that referenced this issue Oct 21, 2019
Scheduled monthly dependency update for September
mmourafiq pushed a commit that referenced this issue Oct 31, 2019
* add k8s 1.16 support

* streams is unready when api server uses SSL+NodePort

* revert postgres dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants