Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pipewire-microphone #440

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Conversation

allddd
Copy link
Contributor

@allddd allddd commented Nov 4, 2023

The --list-targets option was removed from pw-cat in ecff225b, which broke the script (#436).
In my opinion it's not really necessary, since it can be done with pactl.
Other changes mainly concern style/efficiency.

@x70b1
Copy link
Member

x70b1 commented Nov 4, 2023

Thanks for the update!
Why is a trailing underscore required in the function names?

@allddd
Copy link
Contributor Author

allddd commented Nov 4, 2023

@x70b1

Why is a trailing underscore required in the function names?

It's just a naming convention commonly used when writing shell/bash.
It helps distinguish internal functions from external functions/tools, but one could argue that it's hardly necessary in a 40-line script.

If you do not like it, I can remove it, it will not affect functionality.

@x70b1
Copy link
Member

x70b1 commented Nov 6, 2023

Its a bid odd at this place. I would also remove the vim config line.
Everything else is fine. I would pull it after these 2 small changes.

@x70b1 x70b1 merged commit 8798346 into polybar:master Nov 6, 2023
1 check passed
@x70b1
Copy link
Member

x70b1 commented Nov 6, 2023

Thanks!

@allddd allddd deleted the fix-pipewire-microphone branch November 6, 2023 19:39
@skjnldsv
Copy link

skjnldsv commented Dec 9, 2023

Why not pactl get-default-source ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants