Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(renderer): Handling of missing root pixmap (#1608)
Polybar had issues when there is no background set or set by a tool like imagemagick which doesn't add the root pixmap to the root window properties. There's not much we can do about it, but at least polybar doesn't crash anymore. Fixes #1582 Fixes #1585 * fix(tray_manager): only enable transparency if neccessary Previously, we always enabled transparency * fix(background_manager): avoid needless fetching * fix(renderer): move logging message to correct place * fix(background_manager): handle dummy pixmap (_XSETROOT_ID) right * fix(background_manager): more initialization + don't free on error Freeing on error is incorrect, since we could still be called again later in which case we still need the resources. * fix(background_manager): add more infos to trace logs * fix(background): correct typo (XROOTMAP -> XROOTPMAP) * fix(background_manager): do not report "no background" as error * style(background_manager): use braces for if Co-Authored-By: bennofs <benno.fuenfstueck@gmail.com> * fix(background_manager): better error message for dummy pixmap Co-Authored-By: bennofs <benno.fuenfstueck@gmail.com> * style(background): some more style fixes * fix(connection): initialize pixmap in all cases in root_pixmap() * style(connection): improve readability using early return
- Loading branch information
Showing
6 changed files
with
56 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters