New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make text module a label #1331
Comments
To be more precise, what I mean is to add an implicit |
I've pushed a PR for this. It was a bit more difficult than my previous patches but at the end I think I got it right and now I understand quite more about how polybar works so I believe I could help with another not too complex issues in the future. I would be thankful if you review the change and will try to improve anything non merge-quality ASAP. |
Revisiting the documentation I realized that this could be worked around, although in an admittedly hackish way, by using a format prefix or suffix which are themselves labels. Nevertheless I think having the main content as a label is not only cleaner but also more consistent with the rest of the modules. |
TIL about the %{T} tag (#1345) which also ameliorates the need for this refactoring. Still, the other reasons (mainly consistency) still hold. |
Closes polybar#1331 Closes polybar#1342 Closes polybar#2673
Closes polybar#1331 Closes polybar#1342 Fixes polybar#2673
Closes polybar#1331 Closes polybar#1342 Fixes polybar#2673
The text module is too inflexible: it's not possible to set left/right padding, it's not possible to change the font, etc. Why not making it a label with a %text% token by default? This would be much more flexible and also consistent with most of the other modules (consider script, for a similar one).
The text was updated successfully, but these errors were encountered: