fix(xworkspaces): Assign desktops to correct viewport

[patrick96]

Before the module would just try to evenly distribute desktops
(workspaces) among the viewports.

But since _NET_DESKTOP_VIEWPORT actually maps desktops to viewports,
we can use that information to assign workspaces to the right viewport.

I wasn't able to test this yet since I don't have access to my multimonitor setup right now.

Fixes #1849
Fixes #1764

[codecov]

Codecov Report

Merging #1929 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master   #1929   +/-   ##
======================================
  Coverage    9.39%   9.40%           
======================================
  Files         181     181           
  Lines       10873   10871    -2     
======================================
  Hits         1022    1022           
+ Misses       9851    9849    -2     

Flag	Coverage Δ
#unittests	9.40% <0.00%> (+<0.01%)	⬆️

Impacted Files	Coverage Δ
include/modules/xworkspaces.hpp	0.00% <0.00%> (ø)
include/x11/extensions/randr.hpp	0.00% <ø> (ø)
src/modules/xworkspaces.cpp	0.00% <0.00%> (ø)
src/x11/extensions/randr.cpp	0.93% <0.00%> (+<0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2613fa...0629cf8. Read the comment docs.

[Lomadriel]

I tested this on i3wm and it works quite strangely.
When I launch polybar everything works but if I change the position of my monitors, for example like this:

Then launch polybar, it doesn't report the correct workspaces. However if I create a new workspace on the same screen were polybar is, everything get back to normal.

However i3-msg reports the correct viewport:

i3-msg -t get_outputs | jq

[
  {
    "name": "eDP1",
    "active": true,
    "primary": false,
    "rect": {
      "x": 0,
      "y": 0,
      "width": 1920,
      "height": 1080
    },
    "current_workspace": "8"
  },
  {
    "name": "xroot-0",
    "active": false,
    "primary": false,
    "rect": {
      "x": 0,
      "y": 0,
      "width": 1920,
      "height": 1080
    },
    "current_workspace": null
  },
  {
    "name": "DP1",
    "active": true,
    "primary": true,
    "rect": {
      "x": 0,
      "y": 1080,
      "width": 3440,
      "height": 1440
    },
    "current_workspace": "3"
  }
]

[patrick96]

I'm unable to reproduce this, what program are you using to arrange your screens?

Also, what does xprop -root give you and what does polybar display?

[Lomadriel]

I use arandr. It doesn't seem to be a bug into your code.
i3wm doesn't seem to update the property.

Before creating a new desktop.

_NET_DESKTOP_VIEWPORT(CARDINAL) = 0, 0, 0, 0, 0, 1080, 0, 1080, 0, 1080, 0, 1080, 0, 1080

After:

_NET_DESKTOP_VIEWPORT(CARDINAL) = 0, 0, 0, 0, 0, 0, 1920, 0, 1920, 0, 1920, 0, 1920, 0, 1920, 0

I'll try to investigate that and if I'll see if this is a arandr bug or a i3wm one.

[patrick96]

Yeah, seems like an i3 issue as well. Looks like they don't immediately adjust once the monitor setup changes.

Addressed

[patrick96]

I have filed a report over in the i3 repository: i3/i3#4053

This seems to me indeed like an i3 bug.