Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fedora installation instructions #1976

Merged
merged 1 commit into from Jan 20, 2020
Merged

Conversation

tim77
Copy link
Contributor

@tim77 tim77 commented Dec 28, 2019

Packaged and available in official repos. Now on QA. Please hold a little bit this PR and don't merge until status in Bodhi will be changed from Pending/Testing to Stable.
DeepinScreenshot_select-area_20191228231133

TEAM EDIT:
Closes #1639
Closes #1645

@patrick96
Copy link
Member

Nice, we're getting an official fedora package 😃

I wasn't able to find the spec file for 3.4.2, so I just looked at the one for 3.4.1 listed in BZ#1785874: polybar.spec

I am not really familiar with the syntax and semantics of spec files but I noticed that the spec file only uses BuildRequires. Does that mean that this package has no runtime dependencies and only buildtime dependencies? Because only cmake, gcc, python, sphinx (and technically i3) can be build-only dependencies.

Instead of wireless-tools-devel we recommend you use libnl3-devel. The wireless-tools code is deprecated and only here for backwards compatibility.

@tim77
Copy link
Contributor Author

tim77 commented Dec 28, 2019

I wasn't able to find the spec file for 3.4.2, so I just looked at the one for 3.4.1 listed in BZ#1785874: polybar.spec

https://src.fedoraproject.org/rpms/polybar/blob/master/f/polybar.spec

Does that mean that this package has no runtime dependencies and only buildtime dependencies? Because only cmake, gcc, python, sphinx (and technically i3) can be build-only dependencies.

Yes, this just build-only deps. You can check Requires by:

rpm -qp --requires polybar-3.4.2-2.fc31.x86_64.rpm

Instead of wireless-tools-devel we recommend you use libnl3-devel. The wireless-tools code is deprecated and only here for backwards compatibility.

Fixed. ✅

@patrick96
Copy link
Member

Yes, this just build-only deps. You can check Requires by:
rpm -qp --requires polybar-3.4.2-2.fc31.x86_64.rpm

Interesting. So rpm calculates runtime dependencies dynamically from the libraries linked? That's really cool, I generally like how rpm packages take quite a rigorous approach to dependencies, I'm kind of missing that in Arch.

Anyway, I haven't found any other issues with the package. Thanks a lot for packaging polybar 👍

Also make sure to subscribe to #1971 to get notified about build changes in new releases.

Could you notify us, once this becomes stable and is ready to merge?

@tim77
Copy link
Contributor Author

tim77 commented Jan 17, 2020

Also make sure to subscribe to #1971 to get notified about build changes in new releases.

Sure!

Could you notify us, once this becomes stable and is ready to merge?

There were the holidays + Bodhi was broken for some time but now Polybar already 5 days in Stable repo. 🎉

@patrick96
Copy link
Member

Great. Thanks a lot! Great to have polybar in the official repos 🎉🎉

@patrick96 patrick96 merged commit 34bb35c into polybar:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants