Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpd module: added support for custom artist name if artist is empty #2076

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

koraynilay
Copy link

@koraynilay koraynilay commented Apr 25, 2020

This is my first time contributing to a project through github, so I hope I did everything correctly. Feel free to critique my code (obviously) since it's my first time using c++ properly (I only used C).

The code works tested (should work also on the master branch, but #2075 ) with the latest tarball (sha256sum: 4d22c977969a561f561fdc7a609073854d8fea8a9eec6941e12a80457edcb63a).

To use it you add

;it doesn't matter the order of <unkartist-song>, it just needs to be there
format-online = <unkartist-song> <label-song>

label-song = %cartist% %title%
unkartist-song = whatever

@koraynilay koraynilay marked this pull request as ready for review April 25, 2020 21:59
@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #2076 into master will increase coverage by 0.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2076      +/-   ##
=========================================
+ Coverage    9.39%   9.61%   +0.21%     
=========================================
  Files         181     182       +1     
  Lines       10873   11603     +730     
=========================================
+ Hits         1022    1116      +94     
- Misses       9851   10487     +636     
Flag Coverage Δ
#unittests 9.61% <0.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/modules/mpd.hpp 0.00% <ø> (ø)
src/modules/mpd.cpp 0.00% <0.00%> (ø)
include/components/logger.hpp 38.88% <0.00%> (-2.29%) ⬇️
src/ipc.cpp 0.00% <0.00%> (ø)
src/modules/menu.cpp 0.00% <0.00%> (ø)
include/x11/winspec.hpp 0.00% <0.00%> (ø)
include/adapters/net.hpp 0.00% <0.00%> (ø)
include/events/signal.hpp 0.00% <0.00%> (ø)
include/utils/command.hpp 66.66% <0.00%> (ø)
src/modules/backlight.cpp 0.00% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc42da8...3e79b97. Read the comment docs.

@koraynilay koraynilay closed this Aug 3, 2020
@koraynilay koraynilay reopened this Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant