Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.5.5 #2395

Closed
wants to merge 2 commits into from
Closed

Release 3.5.5 #2395

wants to merge 2 commits into from

Conversation

patrick96
Copy link
Member

@patrick96 patrick96 commented Mar 1, 2021

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Release PR

Description

There was a build issue with older versions of sphinx.

Post-release checklist:

Related Issues & Documents

Includes the fix for #2356

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

The VersionChange class is not available in older versions of sphinx, so
we just disable it

Fixes #2356
@codecov
Copy link

codecov bot commented Mar 1, 2021

Codecov Report

Merging #2395 (1d033ed) into master (fdc670a) will decrease coverage by 2.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2395      +/-   ##
=========================================
- Coverage   10.06%   7.21%   -2.85%     
=========================================
  Files         165     156       -9     
  Lines       13217   10726    -2491     
=========================================
- Hits         1330     774     -556     
+ Misses      11887    9952    -1935     
Flag Coverage Δ
unittests 7.21% <ø> (-2.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/drawtypes/ramp.hpp 0.00% <0.00%> (-50.00%) ⬇️
include/utils/factory.hpp 40.00% <0.00%> (-40.00%) ⬇️
src/drawtypes/ramp.cpp 0.00% <0.00%> (-36.37%) ⬇️
src/utils/color.cpp 88.88% <0.00%> (-3.92%) ⬇️
include/drawtypes/label.hpp 83.33% <0.00%> (-2.39%) ⬇️
src/ipc.cpp 0.00% <0.00%> (ø)
src/modules/fs.cpp 0.00% <0.00%> (ø)
src/modules/i3.cpp 0.00% <0.00%> (ø)
src/modules/cpu.cpp 0.00% <0.00%> (ø)
src/modules/mpd.cpp 0.00% <0.00%> (ø)
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdc670a...1d033ed. Read the comment docs.

@patrick96 patrick96 closed this Mar 1, 2021
@patrick96 patrick96 deleted the hotfix/3.5.5 branch March 1, 2021 20:42
@patrick96
Copy link
Member Author

Merged from the command line. For some reason github didnt' recognize this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant