New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[module/memory] Display MiB instead of GiB when GiB value is less than 1GiB #2488
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2488 +/- ##
==========================================
- Coverage 10.12% 10.11% -0.01%
==========================================
Files 147 147
Lines 10188 10198 +10
==========================================
Hits 1032 1032
- Misses 9156 9166 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Thanks a lot for helping out 😃
Please also add these changes to the CHANGELOG.md
file in the Added
section. Also see the relevant section in CONTRIBUTING.md for more info.
Done! Sorry I missed that part of contributing 😅 |
Looks good now :) I also changed some small things myself, will merge this once CI is done. |
What type of PR is this? (check all applicable)
Description
Memory/swap values can now be displayed in MiB instead of GiB when the value is less than 1 GiB, for better precision.
For example, display 512 MiB instead of 0.50 GiB.
The following tokens have been added to the memory module in order to activate this behavior from config:
Related Issues & Documents
Closes #2472
Documentation (check all applicable)
The documentation of the memory module should be updated with the tokens described earlier, and a description on their behavior.