New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow running polybar without BAR argument #2526
Conversation
The configuration file must declare a single bar to be able to not name it.
Codecov Report
@@ Coverage Diff @@
## master #2526 +/- ##
==========================================
- Coverage 10.47% 10.45% -0.02%
==========================================
Files 147 147
Lines 10166 10182 +16
==========================================
Hits 1065 1065
- Misses 9101 9117 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice :)
The only blocker is that polybar bar-that-doesnt-exist
no longer throws an error.
I also added some suggestion for more user-friendly error messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thanks a lot 😃
The configuration file must declare a single bar to be able to not name
it.
What type of PR is this? (check all applicable)
Description
This PR allows to run
polybar
without BAR argument if the configuration only defines one bar.Related Issues & Documents
Closes #2525
Documentation (check all applicable)