Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipc module action #2528

Merged
merged 9 commits into from Oct 10, 2021
Merged

Ipc module action #2528

merged 9 commits into from Oct 10, 2021

Conversation

dvermd
Copy link
Contributor

@dvermd dvermd commented Oct 8, 2021

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

This PR adds hook, prev, next and reset actions to the ipc module

Related Issues & Documents

Closes #2464

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

Edit: add wiki documentation needs

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #2528 (cdad779) into master (282b0f4) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2528      +/-   ##
==========================================
- Coverage   10.47%   10.42%   -0.06%     
==========================================
  Files         147      147              
  Lines       10166    10220      +54     
==========================================
  Hits         1065     1065              
- Misses       9101     9155      +54     
Flag Coverage Δ
unittests 10.42% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/modules/ipc.hpp 0.00% <ø> (ø)
src/modules/ipc.cpp 0.00% <0.00%> (ø)
src/components/config_parser.cpp 44.72% <0.00%> (-4.94%) ⬇️
src/main.cpp 0.00% <0.00%> (ø)
include/components/config.hpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 282b0f4...cdad779. Read the comment docs.

Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The main thing is that we should make the hook action take 0-based indices. I want to move away from 1-based indices in general, especially when it references lists that are 0-based

doc/user/actions.rst Outdated Show resolved Hide resolved
doc/user/actions.rst Outdated Show resolved Hide resolved
doc/user/actions.rst Show resolved Hide resolved
src/modules/ipc.cpp Outdated Show resolved Hide resolved
src/modules/ipc.cpp Outdated Show resolved Hide resolved
src/modules/ipc.cpp Show resolved Hide resolved
src/modules/ipc.cpp Show resolved Hide resolved
src/modules/ipc.cpp Outdated Show resolved Hide resolved
@patrick96
Copy link
Member

We shouldn't introduce any breaking changes here. initial still has to be 1-based unfortunately.

polybar-msg hook is also still 1-based, this hasn't changed. The only thing that is 0-based is polybar-msg action <NAME> hook.X and this isn't a breaking change because that is new.

@patrick96 patrick96 merged commit 231af35 into polybar:master Oct 10, 2021
@patrick96
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add actions for the ipc module
3 participants