Make it possible to run tests. #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I followed the instructions on https://github.com/polybar/polybar/wiki/Testing, and this happened to me: $ cmake .. -DBUILD_TESTS=ON ... [ 11%] Creating directories for 'googletest' [ 22%] Performing download step (git clone) for 'googletest' Cloning into 'googletest-src'... fatal: invalid reference: master CMake Error at googletest-download/googletest-prefix/tmp/googletest-gitclone.cmake:40 (message): Failed to checkout tag: 'master' make[2]: *** [CMakeFiles/googletest.dir/build.make:99: googletest-prefix/src/googletest-stamp/googletest-download] Error 1 make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/googletest.dir/all] Error 2 make: *** [Makefile:91: all] Error 2 CMake Error at tests/CMakeLists.txt:19 (message): Build step for googletest failed: 2 It looks like the problem is that [googletest](https://github.com/google/googletest/) changed their branch from `master` to `main` at some point. I also fixed a broken link https://github.com/polybar/polybar/wiki/Testing. Hopefully it's intentional that random members of the public such as myself are allowed to do that?
|
Thanks for the fix :) Seems that changed just a few days ago. Their readme still references
Yes, that is intentional, exactly because of things like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
I followed the instructions on
https://github.com/polybar/polybar/wiki/Testing, and this happened to
me:
It looks like the problem is that
googletest changed their branch from
mastertomainat some point.Related Issues & Documents
N/A
Documentation (check all applicable)
https://github.com/polybar/polybar/wiki/Testing. Hopefully it's
intentional that random members of the public such as myself are allowed
to do that?