Redraw tray on wallpaper change, only if transparent

[calculon102]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update
• Other: Replace this with a description of the type of this PR

Description

The tray manager of polybar listens on multiple atoms for the background of the root window. On change of these atoms, it will redraw its window-background and message its tray-client to redraw also.

On fast changes of of background, this leads to immense messaging and eventual flickering of the systray.

This patch tries to soften the issue in a way, that tray-window and its client will only redraw, if the bar has transparency. If not, there should be no reason to redraw on wallpaper-change.

Related Issues & Documents

calculon102/xgifwallpaper#7

Documentation (check all applicable)

• This PR requires changes to the Wiki documentation (describe the changes)
• This PR requires changes to the documentation inside the git repo (please add them to the PR).
• Does not require documentation changes

[patrick96]

Looks good 👍

I unfortunetaly don't know enough about the pseudo-transparency code to say for certain that polybar has to redraw in this way everytime.

[codecov]

Codecov Report

Merging #2604 (cdf9e0f) into master (f5bfbcc) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #2604   +/-   ##
=======================================
  Coverage   11.93%   11.93%           
=======================================
  Files         153      153           
  Lines       11297    11294    -3     
=======================================
  Hits         1348     1348           
+ Misses       9949     9946    -3     

Flag	Coverage Δ
unittests	11.93% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/x11/tray_manager.cpp	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5bfbcc...cdf9e0f. Read the comment docs.