Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tray: Embed in bar window #2609

Merged
merged 69 commits into from
Mar 25, 2023
Merged

Commits on Apr 15, 2022

  1. Cleanup tray code

    patrick96 committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    18485d0 View commit details
    Browse the repository at this point in the history
  2. Make tray window a bar subwindow

    Currently requires a dirty workaround to prevent tray icons with
    different depths from crashing
    patrick96 committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    3244b10 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba0e478 View commit details
    Browse the repository at this point in the history
  4. xcb: Cleanup value packing

    patrick96 committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    7acd4c7 View commit details
    Browse the repository at this point in the history
  5. Remove unused parameter

    patrick96 committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    6fa85d2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ab2b5f6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    ab7612e View commit details
    Browse the repository at this point in the history
  8. Fix screen messing up if client docking fails

    The client window has to be added to the save set after it has been
    reparented. Otherwise if the reparenting fails weird stuff happens
    (windows in the save set have to be child windows of windows created by
    the current connection).
    patrick96 committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    9544130 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3711e99 View commit details
    Browse the repository at this point in the history
  10. Fix BadMatch error for wrapper window

    The wrapper window must define a border background if the depth doesn't
    match the parent window.
    patrick96 committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    b8c275d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    9b1afe7 View commit details
    Browse the repository at this point in the history
  12. controller: Keep only eventloop in try-catch

    If an exception is thrown earlier, stopping the eventloop produces an
    error.
    patrick96 committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    6043f85 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    b5c742a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    48d8187 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    81d1f74 View commit details
    Browse the repository at this point in the history
  16. tray: Reuse bar visual

    patrick96 committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    bdfe655 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    9ad73da View commit details
    Browse the repository at this point in the history
  18. --wip-- [skip ci]

    patrick96 committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    d743a22 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2022

  1. Configuration menu
    Copy the full SHA
    4bbb28b View commit details
    Browse the repository at this point in the history
  2. tray: Remove background_manager

    The tray window uses the pixmap of the bar window and clears window
    content on every update.
    patrick96 committed Jul 25, 2022
    Configuration menu
    Copy the full SHA
    9c75954 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. Configuration menu
    Copy the full SHA
    dca9e15 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2022

  1. tray: Remove tray window

    Each tray client is directly reparented to the bar window. This saves us
    the hassle of having to configure a basically useless tray window and
    keeping its background pixmap in sync.
    
    The only disadvantages are having to (un)map each client window
    individually and calculating its position relative to the bar window
    (which changes all the time) instead of relative to the tray window
    (which only changes when clients are added/removed).
    patrick96 committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    ef06472 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2022

  1. tray: Cleanup tray settings

    patrick96 committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    d658c07 View commit details
    Browse the repository at this point in the history
  2. tray: Remove mutex

    patrick96 committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    de560fe View commit details
    Browse the repository at this point in the history
  3. tray: Stop listening to ui::visibility_change

    If the bar window (un)maps, the tray icons are automatically (un)mapped
    patrick96 committed Aug 28, 2022
    Configuration menu
    Copy the full SHA
    1dcff93 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ffcdf7d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    03a2e6b View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2022

  1. Configuration menu
    Copy the full SHA
    b72458a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1127792 View commit details
    Browse the repository at this point in the history
  3. tray: Fix tray not updating after (un)map_notify

    The issue was that the event was for the wrapper window and that the
    tray_client's move constructors didn't correctly copy over all data and
    so when the m_clients vector grew, it corrupted the state of all
    existing clients.
    patrick96 committed Sep 3, 2022
    Configuration menu
    Copy the full SHA
    901183a View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. Configuration menu
    Copy the full SHA
    fe96602 View commit details
    Browse the repository at this point in the history
  2. tray: Fix build error

    patrick96 committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    3b9ff04 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2022

  1. Configuration menu
    Copy the full SHA
    ea5ffdd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    60173e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Configuration menu
    Copy the full SHA
    8ec9807 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. tray: Cleanup logging

    patrick96 committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    5fd62ed View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. Configuration menu
    Copy the full SHA
    63c6b13 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Configuration menu
    Copy the full SHA
    627d43d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0c223ae View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2022

  1. Configuration menu
    Copy the full SHA
    5c38d5c View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Configuration menu
    Copy the full SHA
    def2682 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2022

  1. Configuration menu
    Copy the full SHA
    463ef96 View commit details
    Browse the repository at this point in the history
  2. Remove unused operator==

    patrick96 committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    ae3deab View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Add .cache to gitignore

    Used by clangd
    patrick96 committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    2e902fe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0096fea View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2022

  1. tray: Fix infinite update loop

    tray_client::clear_window is called on expose events for the wrapper
    window, thus it must not produce expose events for itself again.
    patrick96 committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    3cfa012 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. cleanup

    patrick96 committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    d699765 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2022

  1. Configuration menu
    Copy the full SHA
    6d74ae5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7049c75 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Configuration menu
    Copy the full SHA
    cfe9a81 View commit details
    Browse the repository at this point in the history
  2. tray: Add back legacy tray implementation

    Is used for trays defined through tray-position and nothing else.
    patrick96 committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    ca25b56 View commit details
    Browse the repository at this point in the history
  3. tray: Cleanup

    patrick96 committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    f5d1689 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d296d67 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Remove screen realloc argument

    Replaced with explicit reset function
    patrick96 committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    aadd4ce View commit details
    Browse the repository at this point in the history
  2. Replace wait_for_response with handle callback

    The poll-loop could in theory swallow events which would not be seen by
    the main eventloop
    patrick96 committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    6527988 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Configuration menu
    Copy the full SHA
    e8870d6 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Configuration menu
    Copy the full SHA
    1aeac22 View commit details
    Browse the repository at this point in the history
  2. Remove tray client gc

    Not actually used anywhere
    patrick96 committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    f6172e1 View commit details
    Browse the repository at this point in the history
  3. tray: documentation

    patrick96 committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    89f29fa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    58e0911 View commit details
    Browse the repository at this point in the history
  5. renderer: documentation

    patrick96 committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    47f6d9c View commit details
    Browse the repository at this point in the history
  6. color: fix tests

    patrick96 committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    616b3fe View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2023

  1. Remove TODOs

    Not doign this. Using the desired background as the X window background
    color would require us to always first check before using the pixmap or
    cairo context.
    patrick96 committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    ac589b3 View commit details
    Browse the repository at this point in the history
  2. tray: Remove option TODOs

    They are noted in polybar#2689
    patrick96 committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    3e3a380 View commit details
    Browse the repository at this point in the history
  3. tray: Address rendering related TODOs

    Currently, we don't support 32-bit visuals and don't set
    _NET_SYSTEM_TRAY_VISUAL
    
    It is unclear what happens if the default visual (which is used as a
    fallback if _NET_SYSTEM_TRAY_VISUAL is not set) is 32-bit.
    In that case, we may need to explicitly use a 24-bit visual.
    patrick96 committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    23153c3 View commit details
    Browse the repository at this point in the history
  4. tray: Remove delayed notifications

    Unclear why it is needed, neither i3bar, nor stalonetray do delayed
    notifications
    patrick96 committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    f3ce047 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1174645 View commit details
    Browse the repository at this point in the history
  6. fix(tray): Correct y-position with border

    The border size was not taken into account when calculating the tray
    icon's y-position
    patrick96 committed Mar 25, 2023
    Configuration menu
    Copy the full SHA
    04fefa0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    921e2d0 View commit details
    Browse the repository at this point in the history