Fix a Clang 13 warning #2613
Merged
Fix a Clang 13 warning #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick96
force-pushed
the
fix_clang13_warning
branch
2 times, most recently
from
cfb20b8
to
b94c451
Compare
`-Wdeprecated-copy` found this copy-assignment operator, which it complains about. Since it is just `= default`, we should be able to remove both it and the default constructor, making the struct just its data members.
patrick96
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
-Wdeprecated-copyfound this copy-assignment operator, which itcomplains about. Since it is just
= default, we should be able toremove both it and the default constructor, leaving the struct as just its
data members.
Related Issues & Documents
Documentation (check all applicable)