fix(script): Prevent stalling during shutdown #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick96
force-pushed
the
fix/script-hang
branch
from
9336794
to
bbf606a
Compare
If a script module is waiting on a non-tailed script to finish, polybar cannot shut down until the script has terminted. To remedy this, we use the same polling loop as for tailed scripts which checks if it needs to terminate after every iteration.
Codecov Report
@@ Coverage Diff @@
## hotfix/3.6.1 #2621 +/- ##
================================================
- Coverage 11.92% 11.91% -0.02%
================================================
Files 153 153
Lines 11301 11313 +12
================================================
Hits 1348 1348
- Misses 9953 9965 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
If a script module is waiting on a non-tailed script to finish, polybar
cannot shut down until the script has terminted.
To remedy this, we use the same polling loop as for tailed scripts which
checks if it needs to terminate after every iteration.
Related Issues & Documents
Documentation (check all applicable)