Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mpd hide itself when it finishes playing the queue #2645

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheMagzuz
Copy link

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Before, the module would stay visible when it finished the queue, leaving behind all its' icons, which looked a bit silly.
This fixes that, without interfering with the 'stop' functionality. I don't think adding a config flag for this is super necessary, since this feels like a logical extension of hiding the module when the playlist is empty

Related Issues & Documents

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
    • The line on the wiki page for the mpd module, describing that the module won't show if the playlist is empty, might need to be amended to document this new behaviour
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

Before, the module would stay visible when it finished the queue,
leaving behind all its' icons, which looked a bit silly.
This fixes that, without interfering with the 'stop' functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant