fix code in order to support cmake unity builds #2851
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
I tired building polybar with
CMAKE_UNITY_BUILD":"ON"
and the build failed.The
#pragma once
in base.inl is needed because it is included multiple times when passed to the compiler.I am not exactly sure why the changes in encoder.cpp are needed. However, both gcc and clang fail. The variable
header
could be renamed Instead of addingpolybar::
toipc::header
. However, this would change more lines.Both changes should have no impact on the runtime ore a normal build.
Related Issues & Documents
Documentation (check all applicable)