Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reapply colors for padding after suffix #2898

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

indev29
Copy link
Contributor

@indev29 indev29 commented Jan 18, 2023

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Not the prettiest, but straightforward solution for #2814.

I've read #544 and #729 and figured that prefixes do respect "parent" colors, while suffixes don't.

format-prefix = "prefix"
; format-prefix-background = #ff0000
format-suffix = "suffix"
; format-suffix-background = #00ff00
; format-suffix-foreground= #000000
format-background = #0000ff
format-padding = 15px

image

We can fix this in the same PR by reapplying colors before suffix, but this is somewhat breaking.

Related Issues & Documents

Closes #2814

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #2898 (9f0b22a) into master (fc423c0) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #2898   +/-   ##
=======================================
  Coverage   13.17%   13.17%           
=======================================
  Files         162      162           
  Lines       11509    11506    -3     
=======================================
  Hits         1516     1516           
+ Misses       9993     9990    -3     
Flag Coverage Δ
unittests 13.17% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/modules/meta/base.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: format-padding only applies to left side of workspaces block in i3 module
1 participant