Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tray): check for visibility when docking #2973

Merged
merged 1 commit into from Jun 13, 2023

Conversation

anhnamtran
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Fixes an issue where the tray docking logic does not account for the tray's visibility when docking new clients.

The fix is relatively simple as it just sets client->hidden to the tray's manager's before calling ensure_state.

Related Issues & Documents

Fixes #2968

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #2973 (73188e5) into master (2cd0809) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2973      +/-   ##
==========================================
- Coverage   12.69%   12.69%   -0.01%     
==========================================
  Files         160      160              
  Lines       12530    12531       +1     
==========================================
  Hits         1591     1591              
- Misses      10939    10940       +1     
Flag Coverage Δ
unittests 12.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/x11/tray_manager.cpp 0.00% <0.00%> (ø)

@patrick96 patrick96 merged commit c747599 into polybar:master Jun 13, 2023
9 checks passed
@anhnamtran anhnamtran deleted the hiddenTrayDocking branch June 13, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tray: New icons are visible even if tray module is hidden
2 participants