Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for config #2976

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add tests for config #2976

wants to merge 1 commit into from

Conversation

dvermd
Copy link
Contributor

@dvermd dvermd commented Jun 10, 2023

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Add tests for config class

Description

Testing dereference* functions is not part of this PR. Only public methods are tested.

Related Issues & Documents

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Merging #2976 (4bd3cfa) into master (2cd0809) will increase coverage by 1.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2976      +/-   ##
==========================================
+ Coverage   12.69%   14.17%   +1.47%     
==========================================
  Files         160      160              
  Lines       12530    12532       +2     
==========================================
+ Hits         1591     1776     +185     
+ Misses      10939    10756     -183     
Flag Coverage Δ
unittests 14.17% <ø> (+1.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant