Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(renderer): Add fixed-right config option #2985

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lilweege
Copy link

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Changes

This patch adds a new config option (namely fixed-right). Enabling this option changes the default behavior for the alignment of modules-right in certain cases.

Motivation

In my personal config, I use the xwindow module, normally there is no problem with this:
2023-06-25_20-40

However, if either the left or center modules take up too much space (this is not specific to xwindow, but in general), the right modules are pushed off the screen.

With fixed-right = false (current bevahior):
2023-06-25_20-41

With fixed-right = true:
2023-06-25_20-41_1

This patch is useful for my personal config, so I figured it might be useful for others as well. Feedback is appreciated.

Related Issues & Documents

I couldn't find any open issues related to this.

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)

Add a description for the new fixed-right option in the Bar settings section.

  • This PR requires changes to the documentation inside the git repo (please add them to the PR).

Potentially a changelog entry.

  • Does not require documentation changes

@lilweege lilweege changed the title Add fixed-right config option feat(renderer): Add fixed-right config option Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant