Config value

[dvermd]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update
• Other: Replace this with a description of the type of this PR

Description

This PR introduces the config::value type and use it all over polybar.
Instead of reading configuration values from concatenation of string keys to form the whole key, config::value provides a [] operator used to compose new keys.

Related Issues & Documents

This is a preliminary refactor towards a new configuration format and #2391

Documentation (check all applicable)

• This PR requires changes to the Wiki documentation (describe the changes)
• This PR requires changes to the documentation inside the git repo (please add them to the PR).
• Does not require documentation changes

[codecov]

Codecov Report

Merging #3033 (de099da) into master (f7a7557) will increase coverage by 2.54%.
The diff coverage is 22.15%.

@@            Coverage Diff             @@
##           master    #3033      +/-   ##
==========================================
+ Coverage   12.69%   15.24%   +2.54%     
==========================================
  Files         160      160              
  Lines       12533    12760     +227     
==========================================
+ Hits         1591     1945     +354     
+ Misses      10942    10815     -127     

Flag	Coverage Δ
unittests	15.24% <22.15%> (+2.54%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
include/adapters/script_runner.hpp	0.00% <ø> (ø)
include/drawtypes/animation.hpp	0.00% <ø> (ø)
include/drawtypes/label.hpp	100.00% <ø> (+5.26%)	⬆️
include/drawtypes/ramp.hpp	66.66% <ø> (ø)
include/modules/backlight.hpp	0.00% <ø> (ø)
include/modules/battery.hpp	0.00% <ø> (ø)
include/modules/fs.hpp	0.00% <ø> (ø)
include/modules/ipc.hpp	0.00% <ø> (ø)
include/utils/command.hpp	0.00% <ø> (ø)
include/utils/string.hpp	81.81% <ø> (+9.09%)	⬆️
... and 43 more

... and 2 files with indirect coverage changes

[patrick96]

This looks very promising :D

I unfortunately don't really have time to review this right now, any spare time I have, I want to put into finishing the next release.

But in general, I very much agree with the concept of giving modules a view of their own section without them having to select their section every time

And of course the testing infrastructure will also be very useful ;)