Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio unmute on scroll #3072

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Conversation

roddyrap
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

Added the option unmute-on-scroll to the alsa and pulseaudio modules. If this option is false (The default) then there is no difference in behaviour from the previous version. If the option is true, when the user uses the scrollwheel on the module, the sound will be unmuted.

Related Issues & Documents

Closes #3067

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

It might be worth to mention this as an option in the wiki, so that folks could be aware of it.

Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please also update the descriptions of the inc and dec actions for the two modules to mention the unmute-on-scroll.

include/modules/alsa.hpp Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/modules/alsa.cpp Outdated Show resolved Hide resolved
src/modules/pulseaudio.cpp Outdated Show resolved Hide resolved
This will allow users to specify in their config if they want the mixers
to unmute if they use the scroll wheel on the module.
This will allow users to specify in their config if they want the mixers
to unmute if they use the scroll wheel on the module.

Closes: polybar#3067
Copy link
Member

@patrick96 patrick96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now :)

@patrick96 patrick96 merged commit 11b522c into polybar:master Jan 17, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Pulseaudio volume increases on scroll when muted, but doesn't unmute
2 participants