Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(label): Misbehaving min-length tokens with non-ASCII characters #3090

Merged
merged 2 commits into from
Feb 10, 2024

Conversation

patrick96
Copy link
Member

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Other: Replace this with a description of the type of this PR

Description

This is just #3087 ported to the 3.7.2 release branch

Related Issues & Documents

Closes #3087
Fixes #3074

Documentation (check all applicable)

  • This PR requires changes to the Wiki documentation (describe the changes)
  • This PR requires changes to the documentation inside the git repo (please add them to the PR).
  • Does not require documentation changes

nklloyd and others added 2 commits February 10, 2024 12:48
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (8e04f15) 12.69% compared to head (884eed4) 12.69%.

❗ Current head 884eed4 differs from pull request most recent head 5487af6. Consider uploading reports for the commit 5487af6 to get more accurate results

Files Patch % Lines
src/drawtypes/label.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           hotfix/3.7.2    #3090      +/-   ##
================================================
- Coverage         12.69%   12.69%   -0.01%     
================================================
  Files               160      160              
  Lines             12528    12529       +1     
================================================
  Hits               1591     1591              
- Misses            10937    10938       +1     
Flag Coverage Δ
unittests 12.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patrick96 patrick96 merged commit 0206997 into polybar:hotfix/3.7.2 Feb 10, 2024
7 checks passed
@patrick96 patrick96 added this to the 3.7.2 milestone Feb 10, 2024
@patrick96 patrick96 deleted the fix/token-minlength branch February 18, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants