Use std::free for shared_generic_event_ptr

Otherwise it would use `delete` which would probably trigger UB
polybar · Sep 13, 2022 · 343dc77 · 343dc77
1 parent 7a9960b
commit 343dc77
Showing 1 changed file with 3 additions and 18 deletions.
diff --git a/include/xpp/core.hpp b/include/xpp/core.hpp
@@ -151,30 +151,23 @@ class core
     shared_generic_event_ptr
     poll_for_event(void) const
     {
-      return shared_generic_event_ptr(xcb_poll_for_event(m_c.get()));
+      return shared_generic_event_ptr(xcb_poll_for_event(m_c.get()), std::free);
     }
 
     virtual
     shared_generic_event_ptr
     poll_for_queued_event(void) const
     {
-      return shared_generic_event_ptr(xcb_poll_for_queued_event(m_c.get()));
+      return shared_generic_event_ptr(xcb_poll_for_queued_event(m_c.get()), std::free);
     }
 
     virtual
     shared_generic_event_ptr
     poll_for_special_event(xcb_special_event_t * se) const
     {
-      return shared_generic_event_ptr(xcb_poll_for_special_event(m_c.get(), se));
+      return shared_generic_event_ptr(xcb_poll_for_special_event(m_c.get(), se), std::free);
     }
 
-    // virtual
-    // shared_generic_event_ptr
-    // poll_for_special_event(const std::shared_ptr<xcb_special_event_t> & se) const
-    // {
-    //   return poll_for_special_event(se.get());
-    // }
-
     virtual
     shared_generic_event_ptr
     wait_for_special_event(xcb_special_event_t * se) const
@@ -183,14 +176,6 @@ class core
                       xcb_wait_for_special_event(m_c.get(), se));
     }
 
-    // virtual
-    // shared_generic_event_ptr
-    // wait_for_special_event(const std::shared_ptr<xcb_special_event_t> & se) const
-    // {
-    //   return wait_for_special_event(se.get());
-    // }
-
-    // xcb_special_event_t has incomplete type -> no std::shared_ptr
     virtual
     xcb_special_event_t *
     register_for_special_xge(xcb_extension_t * ext,