Fix map reuse when reloading TC egress program of XDP cubes #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reloading a program the new program needs to reuse the maps of the old one. In the EGRESS path of XDP cubes moreover the two programs (TC and XDP) need to share the same maps to beahve as one. For the TC program stealing the map from the old TC program didn't work, causing it to use a new map different from the XDP counterpart. With this fix the TC program directly uses the map of the XDP counterpart.
|
Moved on master to perform tests |
frisso
approved these changes
Dec 13, 2020
frisso
approved these changes
Dec 13, 2020
|
Nice spot, Federico: thanks! |
palexster
approved these changes
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug when reloading a program in the egress path of a XDP cube: XDP egress is emulated with two programs, a TC one to handle packets coming from the stack and a XDP one to handle packets coming from other XDP cubes. This programs should share the same maps in order to behave as one. There is a bug that causes these maps to differ after a reload. This patch fixes the problem.