Use pull_request_target event to trigger CI tests #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike pull_request, this event allows to access secrets
frisso
approved these changes
Apr 14, 2021
palexster
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
pull_requestevent secrets are not accessible due to security reasons. This causes all PR tests to fail since secrets are needed to send Slack notifications and to push test docker images.This PR replaces the
pull_requestevent withpull_request_target. With this event the workflow is executed in the target context, meaning that it executes only the workflow already present in the master, unlikepull_requestthat executes the workflows contained in the PR. This allows to access secrets.This is only a temporary solution since automatically checking out an unknown PR may still pose some security issues.