Universal output redirection, more exit handling #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trading one junk drawer for another, to some extent (I hate code called "util"), but it does seem fair to say at least that none of this code will be used outside of executor implementations. Signed-off-by: Eric Myhre <hash@exultant.us>
Signed-off-by: Eric Myhre <hash@exultant.us>
Signed-off-by: Eric Myhre <hash@exultant.us>
All tests toss output on the floor. The real main message passes information to the user on os.Stderr. Signed-off-by: Eric Myhre <hash@exultant.us>
Signed-off-by: Eric Myhre <hash@exultant.us>
This is the last thing that was pushing output out-of-place through our test harnesses! Hooray! Signed-off-by: Eric Myhre <hash@exultant.us>
Signed-off-by: Eric Myhre <hash@exultant.us>
| fmt.Fprintf(logFile, "\n") | ||
| fmt.Fprintf(logFile, "Full error:\n") | ||
| fmt.Fprintf(logFile, "-----------\n") | ||
| fmt.Fprintf(logFile, "%s\n", caught) |
There was a problem hiding this comment.
Print the message without the stack?
|
LGTM for an initial overhaul. This looks good until we get more aggressive about an output overhaul. |
Simultaneously, add a little more data to the full form logs. The structural serialization is often redundant... but occasionally adds some really useful precision. Signed-off-by: Eric Myhre <hash@exultant.us>
warpfork
force-pushed
the
silence-is-golden
branch
from
4cdd225
to
695a23b
Compare
|
Added a little more terseness for the default user facing message; should be better. |
kofalt
added a commit
that referenced
this pull request
Apr 13, 2015
Universal output redirection, more exit handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All output from the CLI can now be shunted to any
io.Writer. Tests can use this to check output. Right now, existing tests route everything toioutil.Discardfor lack of any useful assertions.This cleans up all output leaking through test reports, making reading much more pleasant again.
Introduced new errors for user-facing messages, with graceful reporting for and a mechanism for custom exit codes, as well as a polite logging mechanism for unexpected errors.