Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Quick and Nimble with XCTest #12

Merged
merged 4 commits into from Aug 26, 2019
Merged

Conversation

bcylin
Copy link
Collaborator

@bcylin bcylin commented Aug 10, 2019

Quick and Nimble caused unexpected errors when running tests on CI. Replacing it with simple XCTest cases should resolve the difficulties after switching to Xcode 10.

Part the subsequent updates of #9.

⬜️ Remove R.swift
⬜️ Replace Freddy with Swift Codable
✅ Replace Quick and Nimble with XCTest
⬜️ Update the project to Xcode 10.3 with Swift 5

⚠️ Not ready to merge until the previous three PRs are merged. The base branch needs to be updated.

@bcylin bcylin requested a review from dlackty August 10, 2019 21:12
@codecov
Copy link

codecov bot commented Aug 10, 2019

Codecov Report

Merging #12 into feature/codable will increase coverage by 0.51%.
The diff coverage is n/a.

Impacted Files Coverage Δ
iCookTV/Models/Video.swift 75.75% <ø> (ø) ⬆️
iCookTV/Models/Category.swift 100% <ø> (+50%) ⬆️

@bcylin bcylin changed the base branch from develop to feature/codable August 10, 2019 22:04
@bcylin bcylin marked this pull request as ready for review August 13, 2019 22:32
Copy link
Member

@dlackty dlackty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's rebase & merge.

@bcylin bcylin merged commit 097ce53 into feature/codable Aug 26, 2019
bcylin added a commit that referenced this pull request Aug 26, 2019
Replace Quick and Nimble with XCTest
@bcylin bcylin deleted the feature/xctest branch August 26, 2019 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants