Swift Codable #11
Merged
Swift Codable #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
bcylin
force-pushed
the
feature/codable
branch
from
5640366
to
9f4e108
Compare
dlackty
reviewed
Aug 16, 2019
dlackty
approved these changes
Aug 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON parsing using Freddy is outdated after Swift 3. This PR replace it with Swift Codable.
Part the subsequent updates of #9.
⬜️ Remove R.swift
✅ Replace Freddy with Swift Codable
⬜️ Replace Quick and Nimble with XCTest
⬜️ Update the project to Xcode 10.3 with Swift 5
Not ready to merge until the previous two PRs are merged. The base branch needs to be updated.