Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gems and migrate to GitHub Actions #14

Merged
merged 5 commits into from Apr 24, 2020
Merged

Conversation

dlackty
Copy link
Member

@dlackty dlackty commented Apr 21, 2020

  • Fix up security alerts
  • Migrate to CocoaPods CDN for faster spec downloads

pod "TreasureData-iOS-SDK", "0.1.15"

target :iCookTVTests do
pod "SwiftLint", podspec: "https://raw.githubusercontent.com/CocoaPods/Specs/master/Specs/4/0/1/SwiftLint/0.34.0/SwiftLint.podspec.json"
pod "SwiftLint", '0.34.0'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@@ -1,4 +1,4 @@
source "https://github.com/CocoaPods/Specs.git"
source 'https://cdn.cocoapods.org/'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@polydicebot
Copy link

1 Error
🚫 Please update CHANGELOG.md.

Generated by 🚫 Danger

@dlackty dlackty force-pushed the feature/update-gems branch 2 times, most recently from fbe29fa to a66a366 Compare April 22, 2020 12:54
@dlackty dlackty force-pushed the feature/update-gems branch 2 times, most recently from 6d23b75 to e35bb2a Compare April 22, 2020 13:12
@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #14 into develop will increase coverage by 1.00%.
The diff coverage is n/a.

Impacted Files Coverage Δ
iCookTV/AppDelegate.swift 31.81% <0.00%> (-2.80%) ⬇️
iCookTV/Models/Video.swift 76.66% <0.00%> (-2.13%) ⬇️
...TV/Controllers/TrackableNavigationController.swift 64.70% <0.00%> (-1.97%) ⬇️
iCookTV/Helpers/Tracker.swift 26.00% <0.00%> (-1.78%) ⬇️
iCookTV/Protocols/DataFetching.swift 85.00% <0.00%> (-1.37%) ⬇️
iCookTV/Metrics.swift 0.00% <0.00%> (ø)
iCookTV/Views/MenuView.swift 0.00% <0.00%> (ø)
iCookTVTests/VideoSpec.swift 100.00% <0.00%> (ø)
iCookTV/Models/Category.swift 100.00% <0.00%> (ø)
iCookTV/Views/VideoCell.swift 0.00% <0.00%> (ø)
... and 21 more

@dlackty dlackty force-pushed the feature/update-gems branch 7 times, most recently from 8ef79c7 to 0b4e50f Compare April 22, 2020 13:38
@dlackty dlackty changed the title Update bunch of gems Update gems and migrate to GitHub Actions Apr 22, 2020
@dlackty dlackty merged commit 2b2caf3 into develop Apr 24, 2020
@dlackty dlackty deleted the feature/update-gems branch April 24, 2020 18:22
@bcylin bcylin removed their assignment Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants