Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danger.systems #4

Merged
merged 4 commits into from Sep 2, 2016
Merged

Danger.systems #4

merged 4 commits into from Sep 2, 2016

Conversation

bcylin
Copy link
Collaborator

@bcylin bcylin commented Aug 26, 2016

http://danger.systems/

@polydice/ios could you please help with a public_repo scope token from @polydicebot for the DangerCI to use?

http://danger.systems/guides/getting_started.html#setting-up-an-access-token

Then add the token as DANGER_GITHUB_API_TOKEN to Travis CI env to see if this works, thanks.

@dlackty
Copy link
Member

dlackty commented Aug 27, 2016

@bcylin Thanks for the pull request.

Just added the required ENV variable but Travis CI failed at brew bundle.
Could you please have a look on it?

@polydicebot
Copy link

polydicebot commented Aug 27, 2016

✅ Congrats.
Please update CHANGELOG.md.

Generated by 🚫 danger

@codecov-io
Copy link

codecov-io commented Aug 28, 2016

Current coverage is 14.04% (diff: 100%)

No coverage report found for develop at a47c3c6.

Powered by Codecov. Last update a47c3c6...af2968d

@dlackty
Copy link
Member

dlackty commented Sep 2, 2016

@bcylin Looks good now. Let's merge in?

@bcylin
Copy link
Collaborator Author

bcylin commented Sep 2, 2016

Sure, thanks!

@dlackty dlackty merged commit 822dc74 into develop Sep 2, 2016
@dlackty dlackty deleted the feature/danger-systems branch September 2, 2016 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants