Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add draft implementation #1

Merged
merged 3 commits into from
May 7, 2021
Merged

Add draft implementation #1

merged 3 commits into from
May 7, 2021

Conversation

dlackty
Copy link
Member

@dlackty dlackty commented May 4, 2021 •
edited
Loading

Goal

Add a draft implementation based on Unified ID 2.0's API documentation.

Considerations

  1. To simplify the code logic, faraday and middlewares are added as dependencies
  2. For common uses cases, user of this project might use API client to consequent API calls, so net-http-persistent is added

Todos

  • Properly handling and validation for API arguments

Discussions

  • What's the right way to pass API arguments? Currently, positional arguments and hash as argument are both used in this project. Should we switch to keyword arguments?

@dlackty dlackty requested a review from YushengLi May 4, 2021 18:21
@dlackty dlackty merged commit 57b44e0 into main May 7, 2021
@dlackty dlackty deleted the draft-implementation branch May 7, 2021 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YushengLi YushengLi Awaiting requested review from YushengLi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dlackty