Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLLT support #24

Closed
Tracked by #75
ahti opened this issue May 3, 2018 · 3 comments
Closed
Tracked by #75

MLLT support #24

ahti opened this issue May 3, 2018 · 3 comments

Comments

@ahti
Copy link

ahti commented May 3, 2018

Would you consider adding a content type for reading and writing MLLT tags?

The quirky thing about this tag is probably that the reference entries contain integers that can be dynamically sized, up to 256 bit. Their combined size has to be a multiple of four, but it seems like the integers themselves could be anything from 1 to 255 bits long (or maybe even 0 to 256? I'm not quite sure how to interpret the tag docs).

So supporting this would probably mean a fair amount of bit-twiddling and depending on something like num-bigint.

A middle way could be to support the meta fields, but decode the references into a single blob that consumers can then further encode/decode themselves.

@polyfloyd
Copy link
Owner

I think it's possible to manually encode and decode these tags using raw Content::Unknown frames.

However, we would happily accept a patch to add proper support for this feature. :)

@ahti
Copy link
Author

ahti commented May 17, 2018

Yes, that is what I have done for now.

For anyone that needs MLLT, this is my implementation, which also generates the mllt table from mp3 frames. It has a fixed number of bits for size and the code isn't very pretty, but it works.

@polyfloyd polyfloyd mentioned this issue Jan 11, 2022
65 tasks
@polyfloyd
Copy link
Owner

MLLT support has been implemented in 0ea0a7f which will be released with 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants