Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of unstable stream_position #68

Closed
ghosty141 opened this issue May 1, 2021 · 2 comments
Closed

Use of unstable stream_position #68

ghosty141 opened this issue May 1, 2021 · 2 comments

Comments

@ghosty141
Copy link

For a project of mine I'm using rust (stable) and when building I get the following message:

error[E0658]: use of unstable library feature 'seek_convenience'
...
let id3_tag_pos = file.stream_position()?;

When checking out the function it says "this is equivalent to self.seek(SeekFrom::Current(0))." which would work in stable.
How about replacing the stream_position calls with seek(SeekFrom::Current(0)) to make this library fully compatible with stable rust?

Have you tried this/what is the reason this unstable feature is needed?

@polyfloyd
Copy link
Owner

At first I was confused because the CI should have caught this. But stream_position has been stabilized in Rust 1.51, which is the latest stable version. Updating your installed Rust version should fix it 👍

@ghosty141
Copy link
Author

ghosty141 commented May 2, 2021

Oh I didn't notice, thanks 👍
What threw me off is, that the tracking issue is still open and I didn't see where it was added to stable rust. rust-lang/rust#59359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants