Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checkbox for each index with a custom analyzer. #8

Merged
merged 1 commit into from
Mar 19, 2013

Conversation

gibrown
Copy link
Contributor

@gibrown gibrown commented Mar 18, 2013

On clusters with 20+ indices the analyzers get very slow when you try and analyze across all analyzers in the cluster.

By default this change disables querying the analyzer until the user selects it.

Could probably use further refinement by sorting the indices based on which ones are enabled, and maybe being able to disable the default analyzers also.

On clusters with 20+ indices the analyzers get very slow when you try and analyze across all analyzers in the cluster.
polyfractal added a commit that referenced this pull request Mar 19, 2013
Add checkbox for each index with a custom analyzer.
@polyfractal polyfractal merged commit af3f4a3 into polyfractal:master Mar 19, 2013
@polyfractal
Copy link
Owner

Thanks!

@gibrown
Copy link
Contributor Author

gibrown commented Mar 19, 2013

Dang, this helped with the slowness when I have 20 indices, but didn't quite fix it. Does the list of index fields and list of indices get updated with every character typed into the text box by any chance?

Any way to disable that? This is the first time I've messed around with Angular.js. Its pretty nice but I think I'm missing something.

@polyfractal
Copy link
Owner

Ah, I think I see the problem:

  • Per-field analyzers aren't affected by the checkbox. This can easily be fixed by including a test for the checkbox in updateFields()
  • ES is being queried for all per-field analyzers, even if they aren't the actively selected field

So if you have twenty indices, with ten properties per mapping, ES is being hit 200 times per character typed. I'll put in a proper fix for this problem tonight.

Tangentially related, Inquisitor should really only ping ES after the user is done typing, instead of after each character. Would help with slowness as well.

@gibrown
Copy link
Contributor Author

gibrown commented Mar 19, 2013

Ah missed that piece. Yeah we have 10s-100s of fields per index. Thanks for looking at this.

@polyfractal
Copy link
Owner

Just pushed an update to master, should theoretically take care of this particular problem (but not the "wait until user is done typing" bug). Let me know how if it helps :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants