Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'shell' command with history and autocomplete support. #106

Closed
tengstrand opened this issue Aug 8, 2021 · 5 comments
Closed

Add a 'shell' command with history and autocomplete support. #106

tengstrand opened this issue Aug 8, 2021 · 5 comments
Assignees
Labels
improvement Not a bug but an improvement to overall user experience
Projects

Comments

@tengstrand
Copy link
Collaborator

Add a 'shell' command (will replace 'prompt') that supports history (with ) and context sensitive autocomplete. Use the jline3 library.

@tengstrand tengstrand created this issue from a note in Polylith (In progress) Aug 8, 2021
@PEZ
Copy link
Contributor

PEZ commented Aug 9, 2021

Have you considered making this the default for the poly command? So it would drop you in to the shell instead of complaining:

  Unknown command ''. Type 'poly help' for help.

@tengstrand
Copy link
Collaborator Author

I guess you mean if you type just "poly" then it should automatically start a shell,
but if you type something like "poly x" then the existing error message could be shown.

I like the idea and I think that is a good default and it will help people getting started!

When the new shell is in place, you will get so much speed and support from it that I believe
this will be the standard way of interacting with the tool.

Good input, and thanks @PEZ !

@PEZ
Copy link
Contributor

PEZ commented Aug 17, 2021

Yes that's exactly what I mean. 😄

@tengstrand tengstrand added the improvement Not a bug but an improvement to overall user experience label Aug 21, 2021
@tengstrand tengstrand self-assigned this Aug 21, 2021
@tengstrand tengstrand moved this from In progress to To do in Polylith Aug 23, 2021
@tengstrand tengstrand moved this from To do to Backlog in Polylith Aug 23, 2021
@tengstrand tengstrand moved this from Backlog to In progress in Polylith Aug 29, 2021
@imrekoszo
Copy link
Contributor

I was able to get command history using clj -Tpoly shell - clj has that built in.

@tengstrand
Copy link
Collaborator Author

Okay cool. The new shell command will also support autocomplete and knows which arguments are relevant for each command + can autocomplete bricks, projects, dirs/files, etcetera.

@tengstrand tengstrand moved this from In progress to To do in Polylith Sep 8, 2021
@tengstrand tengstrand moved this from To do to In progress in Polylith Sep 11, 2021
tengstrand added a commit that referenced this issue Oct 12, 2021
@tengstrand tengstrand moved this from In progress to Done in Polylith Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Not a bug but an improvement to overall user experience
Projects
Development

No branches or pull requests

3 participants