set sop/copy type as enum

polygonjs · Jul 14, 2022 · a088ec5 · a088ec5
1 parent be46c69
commit a088ec5
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/src/engine/expressions/methods/copy.ts b/src/engine/expressions/methods/copy.ts
@@ -1,3 +1,4 @@
+import {SopType} from './../../poly/registers/nodes/types/Sop';
 /**
  * The copy expression allows the copy SOP node to evaluates its input graph multiple times, and vary its result each time.
  *
@@ -41,7 +42,7 @@ export class CopyExpression extends BaseMethod {
 		const node = this.findReferencedGraphNode(indexOrPath) as BaseNodeType;
 		// I'd prefer testing with if(node instanceof CopySopNode || node instanceof CopyAnimNode)
 		// but tslib generates an error when doing so
-		if (node && node.type() == 'copy') {
+		if (node && node.type() == SopType.COPY) {
 			const stampNode = (node as CopyNode).stampNode();
 			return this.createDependency(stampNode, indexOrPath);
 		}

diff --git a/src/engine/nodes/sop/Copy.ts b/src/engine/nodes/sop/Copy.ts
@@ -1,3 +1,4 @@
+import {SopType} from './../../poly/registers/nodes/types/Sop';
 /**
  * Copies a geometry onto every point from the right input.
  *
@@ -68,7 +69,7 @@ const ParamsConfig = new CopySopParamsConfig();
 export class CopySopNode extends TypedSopNode<CopySopParamsConfig> {
 	override paramsConfig = ParamsConfig;
 	static override type() {
-		return 'copy';
+		return SopType.COPY;
 	}
 
 	private _attribNamesToCopy: string[] = [];

diff --git a/src/engine/params/_Numeric.ts b/src/engine/params/_Numeric.ts
@@ -43,7 +43,6 @@ export abstract class TypedNumericParam<T extends ParamType> extends TypedParam<
 					this.emitController.emit(ParamEvent.EXPRESSION_UPDATED);
 				}
 			} else {
-				console.log('this._raw_input', this._raw_input);
 				this.states.error.set(`param input is invalid (${this.path()})`);
 			}
 		}

diff --git a/src/engine/poly/registers/nodes/types/Sop.ts b/src/engine/poly/registers/nodes/types/Sop.ts
@@ -1,4 +1,5 @@
 export enum SopType {
+	COPY = 'copy',
 	PARTICLES_SYSTEM_GPU = 'particlesSystemGpu',
 	SHEAR = 'shear',
 	TRANSFORM = 'transform',