Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The class PLL_OLT_Manager should not unset its properties #1236

Closed
Screenfeed opened this issue Mar 16, 2023 · 0 comments · Fixed by #1246
Closed

The class PLL_OLT_Manager should not unset its properties #1236

Screenfeed opened this issue Mar 16, 2023 · 0 comments · Fixed by #1246
Labels
bug
Milestone
3.4

Comments

@Screenfeed
Copy link
Contributor

At the end of PLL_OLT_Manager::load_textdomains(), the class properties are unset on the purpose to free some memory:

polylang/include/olt-manager.php

Line 162 in bc3eef3

unset( $this->default_locale, $this->list_textdomains, $this->labels );

This can trigger "unknown property" warnings later. Instead we should reset them to their default value:

// Free memory.
$this->default_locale   = null;
$this->list_textdomains = array();
$this->labels           = array();
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.4
2 participants
@Screenfeed @Chouby