[Container] Module Wizard #1032
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sitehealth, sitemaps, sync
Provide public methods to interract with the container, which is now stored in a protected property.
This reverts commit 950cb9c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new container to store and instantiate the Wizard module.
The instance can now be retrieved through the main
$polylangobject (with$polylang->get( 'wizard' )), like all the other modules will be.The instance can still be retrieved in
$polylang->wizardbut a deprecation notice will throw.Follow-up #1012.
Note: based on #1012's branch, needs a rebase before reviewing.