Fix canonical tests and page for posts not redirected #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will avoid to duplicate filters from several instances of PLL_Frontend_Static_Pages (from the test and the PLL_Frontend::init() call in the setup)
Data is only needed when WordPress sitemaps module will generate the actual sitemaps, rewrite rules are not modified.
raaaahman
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Indeed, we needed a first test to run in order to reset the $GLOBAL['wp_sitemaps'] variable: https://github.com/WordPress/wordpress-develop/blob/eb9fb00ee60ed392179f7f8148a2b4fcf6b05ff9/tests/phpunit/includes/abstract-testcase.php#L161
manooweb
reviewed
Nov 23, 2020
| @@ -387,20 +387,20 @@ public function check_canonical_url( $requested_url = '', $do_redirect = true ) | |||
| if ( $this->model->is_translated_taxonomy( $this->get_queried_taxonomy( $wp_query->tax_query ) ) ) { | |||
| $term_id = $this->get_queried_term_id( $wp_query->tax_query ); | |||
| $language = $this->model->term->get_language( $term_id ); | |||
| $redirect_url = get_term_link( $term_id ); | |||
There was a problem hiding this comment.
To make an explanation in a new PR
Chouby
added a commit
that referenced
this pull request
Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the canonical tests:
This revealed that
test_page_for_post_option_should_be_translated_from_plain_permalink()was wrongly passing.=> Fix the code accordingly.