Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a fatal error when the translation group is corrupted #641

Merged
merged 1 commit into from Nov 18, 2020
Merged

Fix a fatal error when the translation group is corrupted #641

merged 1 commit into from Nov 18, 2020

Conversation

Chouby
Copy link
Contributor

@Chouby Chouby commented Nov 18, 2020 •
edited

A fatal error has been reported:

PHP Fatal error: Uncaught Error: Cannot unset string offsets in /home/wp/disk/wordpress/wp-content/plugins/polylang-pro/vendor/wpsyntex/polylang/include/translated-object.php:167

How to reproduce?

  1. Activate Polylang 2.8.4
  2. Create 2 posts translations of each other.
  3. In the database, empty the description for the corresponding translations group term.
  4. Attempt to delete permanently one of the 2 posts.

NB: Unfortunately, we don't know how the description could be removed on the customer's site.

@Chouby Chouby added the bug label Nov 18, 2020
@Chouby Chouby added this to the 2.9 milestone Nov 18, 2020
sebastienserre
sebastienserre approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@sebastienserre sebastienserre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the customer website, I can delete permanently without Fatale Error

manooweb
manooweb approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@manooweb manooweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok 👍

@Chouby Chouby merged commit 7a7648c into master Nov 18, 2020
@Chouby Chouby deleted the fix-delete-translation branch November 18, 2020 15:58
@Chouby Chouby mentioned this pull request Nov 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manooweb manooweb manooweb approved these changes

@sebastienserre sebastienserre sebastienserre approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Chouby @manooweb @sebastienserre