Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote provided slot not resolved for particle in a separate recipe #314

Closed
mariakleiner opened this issue Aug 18, 2017 · 8 comments
Closed
Assignees
Milestone

Comments

@mariakleiner
Copy link
Contributor

arcs-hello-world
If splitting the particles to separate recipes:
recipe
Greet
recipe
PersonalGreet

where
particle Greet
consume root
provide personalGreeting
particle PersonalGreet
consume personalGreeting

after Greet was instantiated, a slot should become available for Personal Greet, but it is not getting resolved by the map-remote-slots strategy.

@mariakleiner mariakleiner added this to the v0.1 - call it done milestone Aug 18, 2017
@mariakleiner mariakleiner self-assigned this Aug 18, 2017
@mariakleiner
Copy link
Contributor Author

this is due to the playground demo only calling the Planner to generate suggestions once.

ui.callback = () => {};

the suggestion-element callback needs to be set to smth that triggers Planner.suggest, similar to the demo-base.js nextStage() method.

@mariakleiner mariakleiner assigned sjmiles and unassigned mariakleiner Aug 18, 2017
@sjmiles
Copy link
Contributor

sjmiles commented Aug 19, 2017

In Arcs CDN v0.03 I implemented regenerating suggestions. Please try it out.

@mariakleiner
Copy link
Contributor Author

Thanks, I tested it with the hello-world and chat glitch apps, and it works fine.

@sjmiles
Copy link
Contributor

sjmiles commented Aug 22, 2017

In the hello-world glitch (https://glitch.com/edit/#!/arcs-hello-world) after choosing 'Hello' I expect 'Greetings to you' to become a suggestion, as per the discussion in this ticket.

I guess it's what I expected to work as per "tested it with the hello-world glitch app".

I must have the wrong expectation, can you explain?

@mariakleiner
Copy link
Contributor Author

in https://arcs-hello-world.glitch.me/
at first I get 2 suggestions:
"Hello and Greetings to you"
"Hello"

after I choose "Hello", I get 4 suggestions, one of which is "Greetings to you".
Is it not what you're getting?

@sjmiles
Copy link
Contributor

sjmiles commented Aug 22, 2017

Sigh. Originally the toast was supposed to open again when there are fresh suggestions, this is the bug in my expectation: because the toast didn't open I assumed there were no suggestions.

A thousand pardons.

@mariakleiner
Copy link
Contributor Author

I actually thought it was a feature, because the demo always behaved like this (I think) - it makes perfect sense to me, when user already has their content on the screen, it might be better for suggestions not to pop up.

@sjmiles
Copy link
Contributor

sjmiles commented Aug 22, 2017

At one point I went to special pains to allow the apps to control this behavior (I think I wanted something different in the VR demo). At any rate, this is ancient history.

After I realized my gaffe, I came to the same conclusion you did (that it's better not to pop-up new stuff until the user asks for it).

Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants